Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom_fields: add remove discovered field button #231

Merged
merged 1 commit into from
Feb 1, 2024
Merged

custom_fields: add remove discovered field button #231

merged 1 commit into from
Feb 1, 2024

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Jan 31, 2024 •
edited
Loading

  • chore: renaming to improve readability
    Screenshot 2024-01-31 at 14 17 57

zzacharo
zzacharo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ping @0einstein0 for the renaming as we reviewed together this!

@kpsherva kpsherva force-pushed the discover-fields branch 2 times, most recently from ba05670 to d10d0df Compare January 31, 2024 15:44
@kpsherva
custom_fields: add remove discovered field button
4be8cc3 
* chore: renaming to improve readability
@slint slint merged commit ee0a38a into inveniosoftware:master Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo zzacharo approved these changes

@0einstein0 0einstein0 0einstein0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpsherva @zzacharo @0einstein0 @slint